oidc-exchange: add workflow_ref to debug msg #305
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@trailofbits.com>
|
CI failure looks unrelated: |
Yep, it was just too slow: |
|
@woodruffw let's maybe also add a warning if the workflow is detected to be reusable? |
Sounds good, I can do that tomorrow! |
|
Maybe we could tell people how exactly they should migrate and point them to subscribe to #166 for news when reusable workflow would become supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow_refandjob_workflow_refdiverge in the "reusable workflow from external repo" case, so having both in the debug output makes it a bit easier to root cause that kind of scenario 🙂